Skip to content

Refactor check for libcurl linkage with OpenSSL < 1.1 #14319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2024
Merged

Refactor check for libcurl linkage with OpenSSL < 1.1 #14319

merged 1 commit into from
Jun 8, 2024

Conversation

petk
Copy link
Member

@petk petk commented May 25, 2024

  • One excessive AC_MSG_RESULT removed
  • AC_RUN_IFELSE wrapped in AC_CACHE_CHECK for easier cross-compiling edge cases
  • Check wrapped in the thread safety condition since this is relevant only when ZTS is enabled

@petk
Refactor check for libcurl linkage with OpenSSL < 1.1
c0ab25f 
- One excessive AC_MSG_RESULT removed
- AC_RUN_IFELSE wrapped in AC_CACHE_CHECK for easier cross-compiling
  edge cases
- Check wrapped in the thread safety condition since this is relevant
  only when ZTS is enabled
@petk petk requested a review from adoy as a code owner May 25, 2024 10:24
@petk
Copy link
Member Author

petk commented Jun 4, 2024

I'll recheck and merge this one in the following days.

@petk petk merged commit 9dbcb91 into php:master Jun 8, 2024
10 checks passed
@petk petk deleted the patch-curl-ssl branch June 8, 2024 16:00
@petk
Copy link
Member Author

petk commented Jun 8, 2024

Rechecked and merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adoy adoy Awaiting requested review from adoy adoy is a code owner

Assignees
No one assigned
Labels
Category: Build System Extension: curl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@petk